Support 3.12 #173
Support 3.12 #173
Conversation
|
I guess this still runs alpha 7, which doesn't have a lot of stuff we need. Let's try again after beta 1 is released. |
|
We could use https://github.com/deadsnakes/action to test with a nightly build in CI. Or, yeah, we could just wait a few days :) |
|
Guessing it'll be a few more days before |
|
What, it was released like two hours ago :D I think I'll cut the 4.6.0 release tonight without waiting for this, after manually confirming that things work on current 3.12. |
|
Seems 3.12-beta1 was just made available (3 hours ago): https://github.com/actions/python-versions/releases/tag/3.12.0-beta.1-5071360807 |
|
Looks like we're still getting alpha7 |
|
Sorry, it seems the manifest needs to be updated still: |
|
We're now getting 3.12-beta1 in CI, but the new test that was added in #188 is failing on 3.12. |
It's a bug in CPython. Writing an issue up now. |
|
|
Following 5d51455, everything should now be green on 3.12 if you merge in |
CHANGELOG.md
Outdated
| @@ -98,7 +98,7 @@ | |||
| as a class rather than a function). This allows user-defined `NewType`s to be | |||
| pickled. Patch by Alex Waygood. | |||
| - Fix tests and import on Python 3.12, where `typing.TypeVar` can no longer be | |||
| subclassed. Patch by Jelle Zijlstra. | |||
| subclassed. Add explicit support for Python 3.12. Patches by Jelle Zijlstra. | |||
There was a problem hiding this comment.
The "Add explicit support for 3.12" bit needs to be moved to the top of the Changelog
No description provided.